tracing: fix sending wrong x-request-id tag #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from header map rewrite.
|
@lyft/network-team cc @jmacd when we do the OT C++ code it would be good to figure out how we can write tests for this bug. It's not clear to me now how we would do that. |
|
+1 |
RomanDzhabarov
approved these changes
Nov 16, 2016
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Jul 20, 2020
… (envoyproxy#226) * build: bump nghttp2 to 1.41.0. (envoyproxy#11412) See release notes at https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0. This addresses GHSA-q5wr-xfw9-q7xr. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Yuchen Dai <silentdai@gmail.com> * build: bump nghttp2 to 1.41.0. (envoyproxy#11412) See release notes at https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0. This addresses GHSA-q5wr-xfw9-q7xr. Set nghttp2 internal flood mitigation threshold back to 10K to avoid any changes in Envoy's codec behavior. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: htuch <htuch@users.noreply.github.com> Co-authored-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: htuch <htuch@users.noreply.github.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…ker-build zh-translation:docs/root/install/sandboxes/local_docker_build.rst
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from header map rewrite.