test: fixing build dependencies #19783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
htuch
reviewed
Feb 4, 2022
htuch
previously approved these changes
Feb 8, 2022
| @@ -429,7 +161,7 @@ TEST_P(VhdsIntegrationTest, RdsUpdateWithoutVHDSChangesDoesNotRestartVHDS) { | |||
| // - Upstream makes a request to an (now) unknown domain | |||
| // - A VHDS DiscoveryResponse received containing update for the domain | |||
| // - Upstream receives a 200 response | |||
| TEST_P(VhdsIntegrationTest, VhdsVirtualHostAddUpdateRemove) { | |||
| TEST_P(VhdsIntegrationTest, DISABLED_VhdsVirtualHostAddUpdateRemove) { | |||
There was a problem hiding this comment.
Why are tests also being disabled?
There was a problem hiding this comment.
whoops - I moved them over and forgot to delete them from the old test file - ditto the commented out tests
htuch
approved these changes
Feb 9, 2022
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9953