-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooling: Fix sync_assignable #17997
tooling: Fix sync_assignable #17997
Conversation
b1c0a7f
to
d6dc760
Compare
this probs conflicts with #17984 - i would prefer that one first |
/assign @envoyproxy/dependency-shepherds |
@envoyproxy/dependency-shepherds cannot be assigned to this issue. |
/lgtm deps |
@zuercher yep i reckon so (ie move forward with this one) |
actually, the other is unblocked and im guessing this tool is rarely used so probs better to wait |
/wait |
d6dc760
to
087668d
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
087668d
to
0482f07
Compare
@zuercher apologies for force push, most of the original changes were rebased out or not required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the build failures are unrelated?
yep, fix just landed on main, ill rerun... |
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: tooling: Fix sync_assignable
Additional Description:
This lib lost its github dependency mostly as it uses a venv.
This shifts it to bazel and fixes the required dependencies
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]