Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "network filters: avoid unnecessary std::shared_ptrs (#14711)" #14755

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Revert "network filters: avoid unnecessary std::shared_ptrs (#14711)" #14755

merged 1 commit into from
Jan 20, 2021

Commits on Jan 19, 2021

  1. Revert "network filters: avoid unnecessary std::shared_ptrs (envoypro… 

    …xy#14711)"

This reverts commit 72db81d.

Per discussion in envoyproxy#14717 and via Slack, we'll come up with a different
approach since using a std::function to keep state presents a few
challenges.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
    Raul Gutierrez Segales committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    5c74e71 View commit details
    Browse the repository at this point in the history