Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement request header processing in ext_proc #14385

Merged
merged 13 commits into from
Jan 11, 2021

Commits on Dec 11, 2020

  1. Add support to ext_proc for request header processing

    Send request headers to the server and apply header mutations based
    on the response. The rest of the protocol is still ignored.
    
    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    5086541 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. Fix an initialization problem

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    66faf2d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Address ext_proc code review

    Make header mutation processing more robust and modular with unit tests.
    
    Add stats to the ext_proc filter and add test assertions.
    
    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    611ec4d View commit details
    Browse the repository at this point in the history
  2. Fix a confusing comment

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    70cefbb View commit details
    Browse the repository at this point in the history
  3. Fix gcc compile and clang-tidy

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    48fe856 View commit details
    Browse the repository at this point in the history
  4. Really fix clang-tidy

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ae1d84c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Code review comments

    Create a common function for the three places that we check
    whether a header may be safely removed from a header map.
    
    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    ab66de1 View commit details
    Browse the repository at this point in the history
  2. Improve code coverage for ext_proc

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    721af9c View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Merge branch 'master' into ext-proc-3

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    f086d09 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Fix a doc problem and a code review comment

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    47cdf80 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Merge branch 'master' into ext-proc-3

    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    dbad315 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Ignore attempts to set sensitive headers

    Ignore attempts to set the host, :authority, :method,
    and any x-envoy headers. We may re-enable some of these later
    when we can write more tests for them.
    
    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    636b488 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Update list of headers not settable by ext_proc

    Add ":scheme" to the list of headers that we will not set.
    Use the proper mechanism to determine the right prefix for special
    headers (usually x-envoy but it can be overridden)
    
    Signed-off-by: Gregory Brail <gregbrail@google.com>
    gbrail committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    47691db View commit details
    Browse the repository at this point in the history