Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 package updates for Retry previous hosts #14118

Merged
merged 5 commits into from
Jan 31, 2021
Merged

v3 package updates for Retry previous hosts #14118

merged 5 commits into from
Jan 31, 2021

Conversation

ankatare
Copy link
Contributor

@ankatare ankatare commented Nov 20, 2020 •
edited
Loading

Commit Message: v3 package updates for Retry previous hosts
Additional Description:
Risk Level: LOW
Testing: Unit ( proto and docs )
Docs Changes: NA
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes:]
[Optional Deprecated:]
part of #12841

@ankatare
v3 package update for previous_hosts proto
a85c97c 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
v3 package update for previous_hosts proto
7fac248 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #14118 was opened by ankatare.

see: more, trace.

@ankatare
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14118 (comment) was created by @ankatare.

see: more, trace.

@ankatare
fixing build issue due to BUILD file
f6fcc16 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@dio
Copy link
Member

dio commented Nov 21, 2020

Seems like you need to update your ./tools/proto_format/proto_format.sh?

@ankatare
Copy link
Contributor Author

@dio Thanks for your inputs. let me check this.

@ankatare
Copy link
Contributor Author

@dio strange !!! seems my local env is updated with master. and i also double checked ./tools/proto_format/proto_format.sh and seems it is also in sync. seems something else is the issue :(

htuch
htuch reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see comments 2/3 in #13814 (comment).

@ankatare
Copy link
Contributor Author

@htuch sure. Thanks for quick review. i will update ASAP

dio
dio reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I think you need to address @htuch's comment and this requires @envoyproxy/api-shepherds approval.

@ankatare
Copy link
Contributor Author

ankatare commented Dec 3, 2020

@dio yeah, working on the same !!!

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 2, 2021
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 9, 2021
@htuch htuch reopened this Jan 11, 2021
htuch
htuch approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Base automatically changed from master to main January 15, 2021 23:01
@ankatare
Copy link
Contributor Author

@htuch please suggest if this can be merged as well ?

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jan 22, 2021
@htuch htuch merged commit f1638fb into envoyproxy:main Jan 31, 2021
@ankatare ankatare deleted the retry_previous_hosts branch February 5, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dio dio dio requested changes

@htuch htuch htuch approved these changes

Assignees

@dio dio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankatare @dio @htuch