Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Add TLS sandbox #13844

Merged
merged 45 commits into from
Nov 11, 2020
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 31, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: examples: Add TLS sandbox
Additional Description:

this provides the following examples

  • http -> https
  • https -> http
  • https -> https
  • https passthrough

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13373
[Optional Deprecated:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax marked this pull request as draft October 31, 2020 09:31
Signed-off-by: Ryan Northey <ryan@synca.io>
.azure-pipelines/pipelines.yml Outdated Show resolved Hide resolved
Signed-off-by: Ryan Northey <ryan@synca.io>
.azure-pipelines/pipelines.yml Outdated Show resolved Hide resolved
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Oct 31, 2020

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
examples/tls/README.md Outdated Show resolved Hide resolved
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
This reverts commit 76c9d60.

Signed-off-by: Ryan Northey <ryan@synca.io>
This reverts commit 92f36fe.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax marked this pull request as ready for review October 31, 2020 18:25
@phlax phlax changed the title [WIP] examples: Add TLS sandbox examples: Add TLS sandbox Oct 31, 2020
@mattklein123 mattklein123 self-assigned this Oct 31, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Nov 11, 2020

@mattklein123 i created a separate pr to handle SNI here #13975 (its early wip)

this one should be ready for final review hopefully - latest render is here https://storage.googleapis.com/envoy-pr/2f6d39c/docs/start/sandboxes/tls.html

worth noting, ive added a "requirements" pullout

its my ~intention to remove all of the "install docker" and "clone envoy repo" sections from the sandboxes and instead link a single page with these instructions - probably from this requirements box

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Nov 11, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13844 (comment) was created by @phlax.

see: more, trace.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to ship and iterate! Very nice!

@mattklein123 mattklein123 merged commit 5fc8127 into envoyproxy:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sandbox: TLS sandbox
2 participants