Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] speed ups for health check fuzzing #13729

Closed
wants to merge 1 commit into from

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Oct 23, 2020

Signed-off-by: Asra Ali asraa@google.com

Commit Message:
Speed up the HTTP health checking portion

  • no need to recreate the whole test session, clear any mocks that hold state
  • only one test session is ever needed since 0 is always hardcoded (there is more simplification that could be done)

Risk Level: Low
Testing: 220 exec/sec -> 500 exec sec

Signed-off-by: Asra Ali <asraa@google.com>
@zasweq
Copy link
Contributor

zasweq commented Oct 23, 2020

Thanks!

@adisuissa
Copy link
Contributor

@asraa is this still a draft?

@asraa
Copy link
Contributor Author

asraa commented Oct 29, 2020

Yes! I'll un-draft it today and ping when ready. Thanks!

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@mattklein123 mattklein123 removed the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@asraa asraa closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants