dependencies: compute and check release dates via GitHub API. #13582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of last_updated was ambiguous (is it when an Envoy contributor creates a PR, merges a commit, or when the dependency is released?). We really are after the release date as a measure of how stale the dependency is. This patch introduces a tool, tools/dependency/release_dates.py, that uses the GitHub API to compute release date. Co-authored-by: Michael Payne <michael@sooper.org> Signed-off-by: Harvey Tuch <htuch@google.com>
repokitteh-read-only
bot
added
the
deps
|
CC @PiotrSikora @envoyproxy/dependency-shepherds |
|
@PiotrSikora @danzh2010 @dio can you update on whether the |
|
@htuch V8's release date should be 2020-08-17 (for 8.5.210.20), BoringSSL's release date is correct. |
dio
reviewed
Oct 15, 2020
danzh2010
reviewed
Oct 15, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
changed the title
repokitteh-read-only
bot
removed
the
deps
|
@lizan this is ready for review; it's stuck on not having GH_ACCESS_TOKEN set, since we need to populate Azure with an access token for "public repo read-only" access to the API. |
|
This PR now passes the new CI "precheck dependencies" :) |
lizan
reviewed
Oct 20, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
repokitteh-read-only
bot
added
the
deps
lizan
approved these changes
Oct 20, 2020
|
MacOS failures looks RBE related, https://dev.azure.com/cncf/envoy/_build/results?buildId=54800&view=logs&j=b4895c6e-031d-5a9e-a507-86b9350b5c70&t=b4ab6edc-d679-5a1d-980f-d72dcbda6eb1. Will force merge. |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 21, 2020
* master: (22 commits) ci: various improvements (envoyproxy#13660) dns: fix defunct fd bug in apple resolver (envoyproxy#13641) build: support ppc64le with wasm (envoyproxy#13657) [fuzz] Added random load balancer fuzz (envoyproxy#13400) dependencies: compute and check release dates via GitHub API. (envoyproxy#13582) mac ci: try ignoring update failure (envoyproxy#13658) watchdog: Optimize WatchdogImpl::touch in preparation to more frequent petting of the watchdog. (envoyproxy#13103) typos: fix a couple 'enovy' mispellings (envoyproxy#13645) lua: Expose stream info downstreamLocalAddress and downstreamDirectRemoteAddress for Lua filter (envoyproxy#13536) tap: fix upstream streamed transport socket taps (envoyproxy#13638) Revert "delay health checks until transport socket secrets are ready. (envoyproxy#13516)" (envoyproxy#13639) Watchdog: use abort action as a default if killing is enabled. (envoyproxy#13523) [fuzz] Fixed divide by zero bug (envoyproxy#13545) wasm: flip the meaning of the "repository" in envoy_wasm_cc_binary(). (envoyproxy#13621) fix: record recovered local address (envoyproxy#13581) docs: fix incorrect compressor filter doc (envoyproxy#13611) docs: clean up docs for azp migration (envoyproxy#13558) wasm: fix building Wasm example. (envoyproxy#13619) test: Refactor flood tests into a separate test file (envoyproxy#13556) wasm: re-enable tests with precompiled modules. (envoyproxy#13583) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of last_updated was ambiguous (is it when an Envoy contributor
creates a PR, merges a commit, or when the dependency is released?).
We really are after the release date as a measure of how stale the
dependency is.
This patch introduces a tool, tools/dependency/release_dates.py, that
uses the GitHub API to compute release date. If a mismatch is detected, an
error is raised.
This patch also introduces a dependency validation CI job that gathers existing
scripts and the release_dates.py script into a single job.
Co-authored-by: Michael Payne michael@sooper.org
Signed-off-by: Harvey Tuch htuch@google.com