ci: bring BAZEL_BUILD_OPTIONS back for format and docs #13480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
to avoid the shellcheck/typing issue, how about renaming |
|
i think the other option is to only change the type on the lines where its being ~exported, so it doesnt change the type globally in the script |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
@phlax ok let's pass it to proto_format only for now. we can do a follow up later, but this lacking of options slows CI down a lot so let's merge this quickly. |
phlax
approved these changes
Oct 11, 2020
mattklein123
approved these changes
Oct 11, 2020
lizan
added a commit
that referenced
this pull request
Oct 21, 2020
Backport following commits to 1.16: 748b2ab (mac ci: try ignoring update failure (#13658), 2020-10-20) f95f539 (ci: various improvements (#13660), 2020-10-20) 6481a27 (ci: stop building alpine-debug images in favor of ubuntu-based debug image (#13598), 2020-10-15) 73d78f8 (ci: use multiple stage (#13557), 2020-10-15) b7a4756 (ci: use azp for api and go-control-plane sync (#13550), 2020-10-14) 876a6bb (ci use azp to sync filter example (#13501), 2020-10-12) a0f31ee (ci: use azp to generate docs (#13481), 2020-10-12) 7e5d854 (ci: bring BAZEL_BUILD_OPTIONS back for format and docs (#13480), 2020-10-11) 7af2b2b (ci: use same flaky test process script on macOS (#13485), 2020-10-10) Signed-off-by: Lizan Zhou <lizan@tetrate.io> Co-authored-by: asraa <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
They got lost in #13169, and we no longer has repository cache for format since then.