check_format: adding 2 more release note checks #13444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
junr03
reviewed
Oct 8, 2020
| @@ -111,7 +111,8 @@ | |||
| PROTO_VALIDATION_STRING = re.compile(r'\bmin_bytes\b') | |||
| VERSION_HISTORY_NEW_LINE_REGEX = re.compile("\* ([a-z \-_]+): ([a-z:`]+)") | |||
| VERSION_HISTORY_SECTION_NAME = re.compile("^[A-Z][A-Za-z ]*$") | |||
| RELOADABLE_FLAG_REGEX = re.compile(".*(.)(envoy.reloadable_features.[^ ]*)\s.*") | |||
| RELOADABLE_FLAG_REGEX = re.compile(".*(..)(envoy.reloadable_features.[^ ]*)\s.*") | |||
| INVALID_REFLINK = re.compile(".* ref:.*") | |||
There was a problem hiding this comment.
is this the only way the reflink is usually invalid? Or is this a way that sphinx compiles/only warns about?
The reason I am asking is I wonder if we should check for this on formatting or if we should allow the sphinx compiler to complain
There was a problem hiding this comment.
It's totally legal.
Prior check mandated that reloadable flags were enclosed in single backticks, but on the latest release Asra caught that two flags out of something like 10 had double backticks, causing formatting inconsistencies by looking different. This is just for visual consistency.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
junr03
approved these changes
Oct 13, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 15, 2020
* master: ci: use multiple stage (envoyproxy#13557) tls: update BoringSSL to 2192bbc8 (4240). (envoyproxy#13567) fix macos v8 build (envoyproxy#13572) Fixed Health Check Fuzz corpus syntax (envoyproxy#13576) ci: Remove shellcheck diff (envoyproxy#13560) ci: Increate brew retry interval (envoyproxy#13565) dependencies: fix some of the fallout from Wasm merge. (envoyproxy#13569) hds: add support for delta updates in specifier (envoyproxy#13067) ci: workaround for actions/runner-images#1811 (envoyproxy#13577) ratelimit: be able to disable x-envoy-ratelimited response header sent (envoyproxy#13270) Update opencensus library (envoyproxy#13549) ci: use azp for api and go-control-plane sync (envoyproxy#13550) docs: Remove/make generic lyft references in docs (envoyproxy#13559) check_format: adding 2 more release note checks (envoyproxy#13444) [Wasm] Add cluster metadata fallback and upstream host metadata (envoyproxy#13477) [fuzz] Added validation for secrets (envoyproxy#13543) Add Platform Specific Feature guidance to PR template (envoyproxy#13547) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure reloadable flags only get one set of backticks, making sure ref links aren't missing the :
Risk Level: n/a (tooling)
Testing: against last release's notes
Docs Changes: n/a
Release Notes: n/a