Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repokitteh: Add welcome message for new contributors #13309

Merged
merged 4 commits into from
Oct 11, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 29, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: repokitteh: Add welcome message for new contributors
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #13232
[Optional Deprecated:]

@phlax phlax marked this pull request as draft September 29, 2020 12:15
@phlax
Copy link
Member Author

phlax commented Sep 29, 2020

cc @itayd

repokitteh.star Outdated Show resolved Hide resolved
@phlax phlax changed the title [WIP] repokitteh: Add welcome message for new contributors repokitteh: Add welcome message for new contributors Sep 30, 2020
@phlax phlax marked this pull request as ready for review September 30, 2020 08:34
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Sep 30, 2020

The output from the welcome message can be seen here #13306 (comment)

@htuch htuch added the area/repokitteh Repokitteh related label Oct 1, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Oct 5, 2020

@itayd i think this one should be ready for review

@phlax
Copy link
Member Author

phlax commented Oct 5, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13309 (comment) was created by @phlax.

see: more, trace.

@phlax phlax mentioned this pull request Oct 7, 2020
itayd
itayd previously approved these changes Oct 8, 2020
ci/repokitteh/modules/newcontributor.star Show resolved Hide resolved
@phlax
Copy link
Member Author

phlax commented Oct 10, 2020

@mattklein123 it would be good to land this, and i would like to test it once it does

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool, just one small comment.

/wait

@@ -0,0 +1,31 @@

NEW_CONTRIBUTOR_MESSAGE = """
hi @%s, welcome and thankyou for your contribution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hi @%s, welcome and thankyou for your contribution.
Hi @%s, welcome and thank you for your contribution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you capitalize Hi?

/wait

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry, on it...

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 5760b8a into envoyproxy:master Oct 11, 2020
@phlax
Copy link
Member Author

phlax commented Oct 11, 2020

@mattklein123 this doesnt seem to have worked on the first pass. I have pinged @itayd to see if we can trace why not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repokitteh Repokitteh related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants