clean up: Change some NOT_IMPLEMENTED to NOT_REACHED #12987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Change some NOT_IMPLEMENTED to NOT_REACHED in case of actually cannot be reached cases.
The NOT_IMPLEMENTED means that it can be filled with meaningful code later but not yet.
The NOT_REACHED means that it never occur so, it is a bug if reach here.
So, I change it to NOT_REACHED actually cannot be reached.
And a default value for protobuf of oneof cannot be selected by config and there is no
valid meaning for logic so I removed it as well.
Signed-off-by: DongRyeol Cha dr83.cha@samsung.com
Additional Description: None
Risk Level: Low
Testing: bazel test
Docs Changes: None
Release Notes: None