-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: add a script to generate debugger config #12917
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
cc @davinci26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some drive by comments feel free to ignore. Also, out of scope, but I wonder if it is possible and what it would take to pre-generate a populated picker list based on this with all targets
That probably need to be a VS Code extension... |
Some of the folks involved with @envoyproxy/windows-dev or @rmiller14 may be knowledgeable in this subject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit, otherwise LGTM
|
||
|
||
def getExecutionRoot(workspace): | ||
# If compilation database exists, use its execution root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explaining why the comp db execution root is preferred might be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/retest |
Retrying Azure Pipelines, to retry CircleCI checks, use |
Commit Message:
Additional Description:
Risk Level: Low
Testing: local
Docs Changes: Added
Release Notes: N/A