Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add a script to generate debugger config #12917

Merged
merged 5 commits into from
Sep 21, 2020

Conversation

lizan
Copy link
Member

@lizan lizan commented Sep 1, 2020

Commit Message:
Additional Description:
Risk Level: Low
Testing: local
Docs Changes: Added
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Sep 1, 2020

cc @davinci26

@snowp snowp self-assigned this Sep 2, 2020
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one suggestion

tools/vscode/README.md Outdated Show resolved Hide resolved
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some drive by comments feel free to ignore. Also, out of scope, but I wonder if it is possible and what it would take to pre-generate a populated picker list based on this with all targets

tools/vscode/generate_debug_config.py Outdated Show resolved Hide resolved
tools/vscode/generate_debug_config.py Outdated Show resolved Hide resolved
tools/vscode/generate_debug_config.py Outdated Show resolved Hide resolved
@snowp snowp added the waiting label Sep 3, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
Copy link
Member Author

lizan commented Sep 4, 2020

Also, out of scope, but I wonder if it is possible and what it would take to pre-generate a populated picker list based on this with all targets

That probably need to be a VS Code extension...

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@wrowe
Copy link
Contributor

wrowe commented Sep 8, 2020

Some of the folks involved with @envoyproxy/windows-dev or @rmiller14 may be knowledgeable in this subject.

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise LGTM



def getExecutionRoot(workspace):
# If compilation database exists, use its execution root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explaining why the comp db execution root is preferred might be nice

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lizan
Copy link
Member Author

lizan commented Sep 21, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #12917 (comment) was created by @lizan.

see: more, trace.

@lizan lizan merged commit 9a4f6f6 into envoyproxy:master Sep 21, 2020
@lizan lizan deleted the vscode_debugger branch September 21, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants