Router Check Tool HeaderMatcher and sendLocalReply

[kb000]

Commit Message:
Set the content-type header in router_check_tool to better match what the real router does.

Additional Description:
This is a re-do of #10183

Risk Level: Low
Testing: Modified existing test, added negative test.
Docs Changes: Noted deprecation of request_header_fields, response_header_fields, addition of request_header_matches, response_header_matches.
Fixes: #10072, #10229

[kb000]

/meow

[kb000]

@dio Do you have any advice on how to keep the deprecated fields in the unit tests but not fail the CI build?

type envoy.RouterCheckToolSchema.ValidationAssert Using deprecated option 'envoy.RouterCheckToolSchema.ValidationAssert.request_header_fields' from file validation.proto.

https://dev.azure.com/cncf/envoy/_build/results?buildId=49507&view=logs&j=ec9f720e-f904-5f65-4ba4-f371a013344f&t=ee47c280-92b1-5c80-3a10-d3d23a58a062&l=4864

[dio]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #12810 (comment) was created by @dio.

see: more, trace.

[dio]

Our CI, @rbe_ubuntu_clang_libcxx//config:platform fails to compile the following (I'm not sure either since it is fine in my local, cc. @lizan):

test/tools/router_check/router.cc:172:67: error: no viable conversion from 'const (lambda at test/tools/router_check/router.cc:162:32)' to 'std::function<void (ResponseHeaderMap &, Code &, std::string &, absl::string_view &)>' (aka 'function<void (Envoy::Http::ResponseHeaderMap &, Envoy::Http::Code &, basic_string<char, char_traits<char>, allocator<char> > &, basic_string_view<char> &)>')
  Envoy::Http::Utility::EncodeFunctions encode_functions{nullptr, encode_headers, encode_data};
                                                                  ^~~~~~~~~~~~~~
/opt/llvm/bin/../include/c++/v1/functional:2283:5: note: candidate constructor not viable: no known conversion from 'const (lambda at test/tools/router_check/router.cc:162:32)' to 'std::nullptr_t' (aka 'nullptr_t') for 1st argument
    function(nullptr_t) _NOEXCEPT {}
    ^
/opt/llvm/bin/../include/c++/v1/functional:2284:5: note: candidate constructor not viable: no known conversion from 'const (lambda at test/tools/router_check/router.cc:162:32)' to 'const std::__1::function<void (Envoy::Http::ResponseHeaderMap &, Envoy::Http::Code &, std::__1::basic_string<char> &, std::__1::basic_string_view<char, std::__1::char_traits<char> > &)> &' for 1st argument
    function(const function&);
    ^
/opt/llvm/bin/../include/c++/v1/functional:2285:5: note: candidate constructor not viable: no known conversion from 'const (lambda at test/tools/router_check/router.cc:162:32)' to 'std::__1::function<void (Envoy::Http::ResponseHeaderMap &, Envoy::Http::Code &, std::__1::basic_string<char> &, std::__1::basic_string_view<char, std::__1::char_traits<char> > &)> &&' for 1st argument
    function(function&&) _NOEXCEPT;
    ^
/opt/llvm/bin/../include/c++/v1/functional:2287:5: note: candidate template ignored: requirement '__callable<(lambda at test/tools/router_check/router.cc:162:32), false>::value' was not satisfied [with _Fp = (lambda at test/tools/router_check/router.cc:162:32)]
    function(_Fp);
    ^

How about to put those functions inline?

  Envoy::Http::Utility::EncodeFunctions encode_functions{
      nullptr,
      [&](Http::ResponseHeaderMapPtr&& headers, bool end_stream) -> void {
        UNREFERENCED_PARAMETER(end_stream);
        Http::HeaderMapImpl::copyFrom(*tool_config.response_headers_->header_map_, *headers);
      },
      [&](Buffer::Instance& data, bool end_stream) -> void {
        UNREFERENCED_PARAMETER(data);
        UNREFERENCED_PARAMETER(end_stream);
      }};

[dio]

Looks good overall, some comments:

[mattklein123]

Awesome, thanks for the changes, much more future proof. Just a few small comments and let's ship!

/wait

[mattklein123]

Awesome, thanks, looks great. Can you merge main? Main was broken for a bit.

/wait

[mattklein123]

Sorry gcc compile error looks legit.

/wait

[kb000]

The compile error doesn't make sense.

test/tools/router_check/router.cc: In function 'const string {anonymous}::toString(envoy::config::route::v3::HeaderMatcher::HeaderMatchSpecifierCase)':
test/tools/router_check/router.cc:51:1: error: control reaches end of non-void function [-Werror=return-type]
   51 | }
      | ^

That switch statement treats all cases. This build error is exactly the safety mechanism we want to future-proof this method.
https://github.com/envoyproxy/envoy/pull/12810/files#diff-be4db2a080dea0422cf3ad8c0ceb7fd3R21-R51

[mattklein123]

Remove the default case and put a NOT_REACHED at the end of the function (outside of the switch) and it will compile. Sorry for the trouble.

/wait

[mattklein123]

Thanks!