Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hcm: avoid invoking 100-continue handling on decode filter. #10929

Merged
merged 2 commits into from
Apr 24, 2020
Merged

hcm: avoid invoking 100-continue handling on decode filter. #10929

merged 2 commits into from
Apr 24, 2020

Commits on Apr 24, 2020

  1. hcm: avoid invoking 100-continue handling on decode filter. 

    The 100-continue state tracking variables were checking in
commonContinue() (on both decode/encode paths), conditioning
do100ContinueHeaders(). This makes no sense on the decode path, and can
lead to crashes as per envoyproxy#10923 when the decode pipeline is resumed, so
refactored the logic out to just the encode path.

Risk level: Low
Testing: Unit and integration regression tests added, as well as corpus
  entry.

Fixes oss-fuzz issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18461

Fixes envoyproxy#10923

Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    5652255 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into decode-100-continue

    @htuch
    htuch committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0df37a9 View commit details
    Browse the repository at this point in the history