Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router: Create InternalRedirectPolicy in side RouteAction and extend it with pluggable predicates #10908

Merged
merged 52 commits into from
May 14, 2020
Merged

router: Create InternalRedirectPolicy in side RouteAction and extend it with pluggable predicates #10908

merged 52 commits into from
May 14, 2020

Commits on Apr 22, 2020

  1. Move internal redirect configs into InternalRedirectPolicy and implement 

    pluggable predicates.

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2d1206f View commit details
    Browse the repository at this point in the history

  2. Generate protobuf. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    15f1510 View commit details
    Browse the repository at this point in the history

  3. Fix typos. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    81debc8 View commit details
    Browse the repository at this point in the history

  4. Fix more typo in the comments. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    e3eee18 View commit details
    Browse the repository at this point in the history

  5. Fix ref links. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    c89a6b4 View commit details
    Browse the repository at this point in the history

  6. Fix link in hcm arch overview. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    0f77ae8 View commit details
    Browse the repository at this point in the history

  7. Fix doc links. For real. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    985819a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. And fix the formats. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    8199c60 View commit details
    Browse the repository at this point in the history

  2. Fix typos. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    fac46f2 View commit details
    Browse the repository at this point in the history

  3. More typo correction. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    fe9e5c9 View commit details
    Browse the repository at this point in the history

  4. More typos. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    179e5a9 View commit details
    Browse the repository at this point in the history

  5. fix clang-tidy findings. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    1c7ada2 View commit details
    Browse the repository at this point in the history

  6. ConfigTest -> PreviousRoutesTest. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    925950c View commit details
    Browse the repository at this point in the history

  7. Format. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    61e15f7 View commit details
    Browse the repository at this point in the history

  8. Kick CI 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a806956 View commit details
    Browse the repository at this point in the history

  9. Kick CI 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    5711900 View commit details
    Browse the repository at this point in the history

  10. Avoid using newly deprecated fields in the integration test. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    684ba65 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Add comments InternalRedirectAction enum values. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    ad05c9b View commit details
    Browse the repository at this point in the history

  2. Run proto_format on proto comment change. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    c606a1e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Address API comments. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    feedb0e View commit details
    Browse the repository at this point in the history

  2. Fix format. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    b5a1f54 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Address API comments. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    23521a6 View commit details
    Browse the repository at this point in the history

  2. Address code comments. allow_cross_scheme_redirect will be address se… 

    …parately in a different commit.

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    dabc625 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Change to allow cross scheme redirect by default. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 1, 2020
    Configuration menu
    Copy the full SHA
    d6d1dce View commit details
    Browse the repository at this point in the history

  2. Fix doc ref links. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 1, 2020
    Configuration menu
    Copy the full SHA
    753e046 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into internal-redirect-more-options

    @penguingao
    penguingao authored May 1, 2020
    Configuration menu
    Copy the full SHA
    9fa3ecd View commit details
    Browse the repository at this point in the history

  4. Fix router:config_impl_test 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 1, 2020
    Configuration menu
    Copy the full SHA
    ceb0fa9 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/internal-redirect-more-options' … 

    …into internal-redirect-more-options

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 1, 2020
    Configuration menu
    Copy the full SHA
    70da0b9 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into internal-redirect… 

    …-more-options

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 1, 2020
    Configuration menu
    Copy the full SHA
    68cad35 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Test that invalid response codes are dropped by InternalRedirectPolicy. 

    Add trace logging to InternalRedirectPredicate.

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    f7beb49 View commit details
    Browse the repository at this point in the history

  2. Fix typo. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    bc525c4 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into internal-redirect… 

    …-more-options

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    8cd5974 View commit details
    Browse the repository at this point in the history

  4. regenerate v4 protos. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    4e06b6d View commit details
    Browse the repository at this point in the history

  5. Add stats for internal redirect. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    8c31bf9 View commit details
    Browse the repository at this point in the history

  6. Fix accidentally broken doc format in http_connection_management.rst 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    db7a8fe View commit details
    Browse the repository at this point in the history

  7. Fix comment. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    cac69d6 View commit details
    Browse the repository at this point in the history

  8. Fix typo. Add counter test in redirection integration test. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    a24ee60 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into internal-redirect… 

    …-more-options
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    c05d049 View commit details
    Browse the repository at this point in the history

  10. Update dictionary. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    1144d82 View commit details
    Browse the repository at this point in the history

  11. NiceMock<MockInternalRedirectPredicate>. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 4, 2020
    Configuration menu
    Copy the full SHA
    9e08926 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Bump stats_integration_test bounds. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c111425 View commit details
    Browse the repository at this point in the history

  2. Adjust stats_integration expectation according to CI. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 5, 2020
    Configuration menu
    Copy the full SHA
    5be8361 View commit details
    Browse the repository at this point in the history

  3. Fix router_test. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 5, 2020
    Configuration menu
    Copy the full SHA
    5c1e199 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Merge remote-tracking branch 'upstream/master' into internal-redirect… 

    …-more-options

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 12, 2020
    Configuration menu
    Copy the full SHA
    8138621 View commit details
    Browse the repository at this point in the history

  2. Move predicate config to use TypedExtensionConfig. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 12, 2020
    Configuration menu
    Copy the full SHA
    8461c5f View commit details
    Browse the repository at this point in the history

  3. Implete OnlyAllowSafeCrossSchemeRedirect internal redirect predicate. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 12, 2020
    Configuration menu
    Copy the full SHA
    56b0188 View commit details
    Browse the repository at this point in the history

  4. Fix format. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 12, 2020
    Configuration menu
    Copy the full SHA
    15a4d3f View commit details
    Browse the repository at this point in the history

  5. Add OnlyAllowSafeCrossSchemeRedirect predicate to docs. Make sure the 

    behavior change is documented in the release note.

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 12, 2020
    Configuration menu
    Copy the full SHA
    948ca63 View commit details
    Browse the repository at this point in the history

  6. Fix previous_route_test. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 12, 2020
    Configuration menu
    Copy the full SHA
    93cd0e6 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Fix clang tidy finding. 

    Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c62f9da View commit details
    Browse the repository at this point in the history

  2. Rename OnlyAllowSafeCrossSchemeRedirect to SafeCrossScheme to get around 

    windows path length limitation.

Change default behavior to be disallowing cross scheme redirect. Rename
the option to allow_cross_scheme (default to false).

Update tests.

Document implemeneted default behavior change.

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 13, 2020
    Configuration menu
    Copy the full SHA
    4e660fd View commit details
    Browse the repository at this point in the history

  3. API comment fix. const vars. Add @param to interface documentation. 

    AllowListed -> Allow listed.

Signed-off-by: pengg <pengg@google.com>
    @penguingao
    penguingao committed May 13, 2020
    Configuration menu
    Copy the full SHA
    416e79e View commit details
    Browse the repository at this point in the history