Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor azp into one pipelines #10564

Merged
merged 1 commit into from
Mar 31, 2020
Merged

ci: refactor azp into one pipelines #10564

merged 1 commit into from
Mar 31, 2020

Conversation

lizan
Copy link
Member

@lizan lizan commented Mar 29, 2020

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Merge all platforms into one pipelines to

  • guard mac and windows CI by format check
  • guard additional checks (asan, tsan, tidy..) by release to reduce CI pressure.
  • not guard docker image build by sanitizers.
  • refactor out bazel steps to another yaml file

Risk Level: Low (CI only)
Testing: CI
Docs Changes:
Release Notes:

@lizan
ci refactor
461a2d3 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from mattklein123 March 29, 2020 21:14
@lizan
Copy link
Member Author

lizan commented Mar 29, 2020 •
edited
Loading

This is pure refactor + reorder, it still shows envoy-linux because I don't want to mess other PRs. I will change it to envoy-presubmit and update GH settings. Then all pending PRs need merge master.

@htuch htuch self-assigned this Mar 30, 2020
htuch
htuch reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the parallelism is not affected (and improved by the guards). Let me know when you are ready to merge.

@lizan
Copy link
Member Author

lizan commented Mar 30, 2020 •
edited
Loading

@htuch it affects parallelism a bit because release guards all sanitizers / gcc. This is ready to go. I can merge myself and update settings later today once you approve.

@lizan lizan merged commit 3804528 into master Mar 31, 2020
@mattklein123 mattklein123 deleted the azp_refactor branch March 31, 2020 15:14
@lizan lizan mentioned this pull request Apr 10, 2020
Closed
lizan added a commit that referenced this pull request May 5, 2020
@lizan
ci: refactor azp into one pipeline (#10564)
2890d8f 
Description:
Merge all platforms into one pipelines to
- guard mac and windows CI by format check
- guard additional checks (asan, tsan, tidy..) by release to reduce CI pressure.
- not guard docker image build by sanitizers.
- refactor out bazel steps to another yaml file

Risk Level: Low (CI only)
Testing: CI
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan added a commit that referenced this pull request May 5, 2020
@lizan
ci: refactor azp into one pipeline (#10564)
174ce2a 
Description:
Merge all platforms into one pipelines to
- guard mac and windows CI by format check
- guard additional checks (asan, tsan, tidy..) by release to reduce CI pressure.
- not guard docker image build by sanitizers.
- refactor out bazel steps to another yaml file

Risk Level: Low (CI only)
Testing: CI
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123

Assignees

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizan @htuch