Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: make error messages less bad #686

Closed
mattklein123 opened this issue Apr 4, 2017 · 1 comment
Closed

config: make error messages less bad #686

mattklein123 opened this issue Apr 4, 2017 · 1 comment
Assignees
@danielhochman
Labels
enhancement Feature requests. Not bugs or questions.
Milestone
1.3.0

Comments

@mattklein123
Copy link
Member

There are 2 major issues right now:

  1. There are no line numbers that get associated with a JsonException. This is fixable if we switch to using the SAX API and build the DOM directly. Then we can feed in the config file one line at a time.

  2. Some of the error messages output either by the main parser or the schema validator are terrible. In particular the schema validator. We need to look at this and see about making the error messages better. This will likely involve raising upstream rapidjson issues and probably doing upstream PRs.
@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted labels Apr 4, 2017
@mattklein123 mattklein123 modified the milestone: 1.3.0 Apr 8, 2017
@mattklein123
Copy link
Member Author

Resolving this for now via #972

We can open new issues depending on how this goes. Line numbers will help a ton. Thanks @danielhochman !

rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
@istio-testing
Update_Dependencies (envoyproxy#686)
bae7ea2 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
jpsim pushed a commit that referenced this issue Nov 28, 2022
@junr03 @jpsim
docs: add stats blog to additional resources (#686)
a66ea6d 
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@junr03 @jpsim
docs: add stats blog to additional resources (#686)
c84a3b9 
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielhochman danielhochman

Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@danielhochman @mattklein123