Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the GRPC-Web spec. #374

Closed
fengli79 opened this issue Jan 24, 2017 · 6 comments
Closed

Implement the GRPC-Web spec. #374

fengli79 opened this issue Jan 24, 2017 · 6 comments
Assignees
@fengli79
Labels
enhancement Feature requests. Not bugs or questions.
Milestone
1.5.0

Comments

@fengli79
Copy link
Contributor

Implements the GRPC web spec: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md
@mattklein123 mattklein123 changed the title Implements the GRPC-Web spec. Implement the GRPC-Web spec. Jan 24, 2017
@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted labels Jan 24, 2017
@fengli79
Copy link
Contributor Author

I'm going to implement this soon, could you help to assign this to me?

@mattklein123
Copy link
Member

@fengli79 before writing a ton of code, can you provide a rough implementation outline? From my limited understanding it seems like this will be an optional filter?

@mattklein123 mattklein123 modified the milestone: 1.4.0 May 19, 2017
@mattklein123
Copy link
Member

@fengli79 should we close this as complete for now? Or do you want to leave this open to track further follow ups?

@fengli79
Copy link
Contributor Author

There's one more thing left. I need to create a PR for error handling. We can close this after that.

@mattklein123 mattklein123 modified the milestones: 1.4.0, 1.5.0 Jul 21, 2017
@mattklein123
Copy link
Member

@fengli79 can we close this out now? Anything else immediate being tracked?

@fengli79
Copy link
Contributor Author

fengli79 commented Oct 3, 2017

Yes, we can close it. It's ready to use.
Further features can be tracked by separate issues.

@fengli79 fengli79 closed this as completed Oct 3, 2017
rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
@mtakigiku @lizan
Update the doc (envoyproxy#374)
8403b51 
* Update the doc

* Fix typo

* Add period

* Add sentence
jplevyak added a commit to jplevyak/envoy that referenced this issue Jan 22, 2020
@jplevyak
Merge pull request envoyproxy#374 from jplevyak/perf
4e12511 
Add Wasm micro benchmarks.
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this issue Jan 23, 2021
@gyyn @majinghe
zh-translation:docs/root/configuration/upstream/health_checkers/redis…
5682901 
….rst (envoyproxy#374)

* _config_health_checkers_redis

* Update docs/root/configuration/upstream/health_checkers/redis.rst

Co-authored-by: majinghe <42570491+majinghe@users.noreply.github.com>

Co-authored-by: majinghe <42570491+majinghe@users.noreply.github.com>
jpsim pushed a commit that referenced this issue Nov 28, 2022
@rebello95 @jpsim
bazel: assert if '-Swift.h' files are not exactly 1 (#374)
eba90d8 
Addressing envoyproxy/envoy-mobile#372 (comment)

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@rebello95 @jpsim
bazel: assert if '-Swift.h' files are not exactly 1 (#374)
0518e0c 
Addressing envoyproxy/envoy-mobile#372 (comment)

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengli79 fengli79

Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@mattklein123 @fengli79