Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport socket extension: gRPC TSI based ALTS support #3429

Closed
lizan opened this issue May 17, 2018 · 4 comments
Closed

transport socket extension: gRPC TSI based ALTS support #3429

lizan opened this issue May 17, 2018 · 4 comments
Assignees
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@lizan
Copy link
Member

lizan commented May 17, 2018

Description:

The proposal is to upstream the ALTS support based on gRPC TSI (transport socket interface) implementation to Envoy main repo.

The current implementation have two part:

  • gRPC TSI based TransportSocket implementation which may be reused to implement other gRPC based transport security (e.g. TLS)
  • ALTS specific TransportSocketConfigFactory to instantiate the TransportSocket.

cc @alyssawilk @htuch

[optional Relevant Links:]
Existing implementation:
https://github.com/istio/proxy/tree/master/src/envoy/alts

@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label May 17, 2018
@alyssawilk
Copy link
Contributor

I believe this falls neatly under our new extension policy, so I think this should be good to go.

This was referenced Jun 11, 2018
@stale
Copy link

stale bot commented Jun 30, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 30, 2018
@stale
Copy link

stale bot commented Jul 7, 2018

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Jul 7, 2018
@danzh2010
Copy link
Contributor

I think this is not done yet.

@lizan lizan reopened this Jul 12, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 12, 2018
@lizan lizan added the no stalebot Disables stalebot from closing an issue label Jul 13, 2018
alyssawilk pushed a commit that referenced this issue Jul 23, 2018
2nd PR for #3429, add frame protector.

Risk Level: Low (not enabled in main)
Testing: bazel test //test/...
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <zlizan@google.com>
lizan added a commit that referenced this issue Aug 31, 2018
3rd PR for #3429, add transport socket implementation.

Risk Level: Low (not enabled in main)
Testing: bazel test //test/...
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <zlizan@google.com>
htuch pushed a commit that referenced this issue Oct 29, 2018
Last one for #3429, introduce ALTS config and add integration test.

Risk Level: Low (extension)
Testing: manual test, integration test, CI
Docs Changes: Done
Release Notes:
Fixes #3429.

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

5 participants