Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_allow_upstream_filters deprecation #26898

Closed
alyssawilk opened this issue Apr 24, 2023 · 0 comments · Fixed by #26916
Closed

envoy_reloadable_features_allow_upstream_filters deprecation #26898

alyssawilk opened this issue Apr 24, 2023 · 0 comments · Fixed by #26916
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #22918 (http: cleaning upstream interfaces for upstream filters.) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Apr 24, 2023
@alyssawilk alyssawilk self-assigned this Apr 24, 2023
@alyssawilk alyssawilk mentioned this issue Apr 24, 2023
Merged
alyssawilk added a commit that referenced this issue Apr 25, 2023
@alyssawilk
runtime: removing envoy.reloadable_features.allow_upstream_filters (#…
7be30f3 
…26916)

Risk Level: Medium (lots of code sites)
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes #26898
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@yanjunxiang-google yanjunxiang-google mentioned this issue May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: removing envoy.reloadable_features.allow_upstream_filters alyssawilk/envoy
1 participant
@alyssawilk