Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional configuration for determining internal address #19844

Closed
ramaraochavali opened this issue Feb 7, 2022 · 3 comments
Closed

additional configuration for determining internal address #19844

ramaraochavali opened this issue Feb 7, 2022 · 3 comments
Labels
area/configuration help wanted Needs help!

Comments

@ramaraochavali
Copy link
Contributor

Title: additional configuration for determining internal address

Description:
Currently Envoy determines whether the address is an internal address or not based on RFC 1918. However in some of our use cases we need RFC 6598. It would also be useful to allow internal subnets to be configurable.

The feature request is to enhance Internal Address Config and add those two parameters.
@ramaraochavali ramaraochavali added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 7, 2022
@ramaraochavali
Copy link
Contributor Author

@snowp @mattklein123 WDYT?

@mattklein123 mattklein123 added area/configuration help wanted Needs help! and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 7, 2022
@mattklein123
Copy link
Member

Sure makes sense to me.

@ggreenway
Copy link
Contributor

I think it would make the most sense to allow configuring a list of CIDRs to be considered internal, and if unset, defaults to the current behavior of RFC 1918.

Related to (or maybe a dupe of) #2590.

@deveshkandpal1224 deveshkandpal1224 mentioned this issue Mar 17, 2022
Closed
@deveshkandpal1224 deveshkandpal1224 mentioned this issue Mar 28, 2022
Merged
ravenblackx pushed a commit to ravenblackx/envoy that referenced this issue Jun 8, 2022
@deveshkandpal1224 @ravenblackx
http conn manager: configure which address ranges are considered inte…
a1c1f24 
…rnal (envoyproxy#20548)

Fixes envoyproxy#19844

Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
@cskarby cskarby mentioned this issue Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/configuration help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattklein123 @ggreenway @ramaraochavali