Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.upstream_http2_flood_checks deprecation #18449

Closed
alyssawilk opened this issue Oct 5, 2021 · 2 comments · Fixed by #19016
Closed

envoy.reloadable_features.upstream_http2_flood_checks deprecation #18449

alyssawilk opened this issue Oct 5, 2021 · 2 comments · Fixed by #19016
Assignees
@yanavlasov
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #14443 (http2: Flip the upstream H2 frame flood and abuse checks to ON by default) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 5, 2021
@alyssawilk
Copy link
Contributor Author

reminder ping :-)

@yanavlasov
Copy link
Contributor

I'll get cranking on it

@yanavlasov yanavlasov mentioned this issue Nov 16, 2021
Merged
lizan pushed a commit that referenced this issue Nov 18, 2021
@yanavlasov
Remove envoy.reloadable_features.upstream_http2_flood_checks runtime …
5d1ed3f 
…override and legacy code paths (#19016)

Remove envoy.reloadable_features.upstream_http2_flood_checks runtime override and legacy code paths.

Risk Level: Low
Testing: Unit Tests
Docs Changes: proto comments updated
Release Notes: Yes
Platform Specific Features: N/A
Fixes #18449

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanavlasov yanavlasov

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove envoy.reloadable_features.upstream_http2_flood_checks and legacy code paths yanavlasov/envoy
2 participants
@yanavlasov @alyssawilk