Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking issue to continue v2 support for upgraded protos in Q1. #14197

Closed
ankatare opened this issue Nov 26, 2020 · 3 comments
Closed

tracking issue to continue v2 support for upgraded protos in Q1. #14197

ankatare opened this issue Nov 26, 2020 · 3 comments
Assignees
@ankatare
Labels
api/v2 api/v3 Major version release @ end of Q3 2019 stale stalebot believes this issue/PR has not been touched recently

Comments

@ankatare
Copy link
Contributor

Title: Opening this issue to track v2 support for protos in Q1.

Description: Opening this issue to track v2 support for following protos in Q1.
refer #12841 for details.

protos:
"//envoy/config/filter/thrift/router/v2alpha1:pkg",
"//envoy/config/health_checker/redis/v2:pkg",
"//envoy/config/resource_monitor/fixed_heap/v2alpha:pkg",
"//envoy/config/resource_monitor/injected_resource/v2alpha:pkg",
"//envoy/config/retry/omit_canary_hosts/v2:pkg",
"//envoy/config/retry/previous_hosts/v2:pkg",

Describe the issue.

[optional Relevant Links:]

see #12841 for details
@ankatare ankatare added the triage Issue requires triage label Nov 26, 2020
@jmarantz jmarantz added api/v2 api/v3 Major version release @ end of Q3 2019 labels Dec 1, 2020
@mattklein123 mattklein123 removed the triage Issue requires triage label Dec 7, 2020
ankatare added a commit to ankatare/envoy that referenced this issue Dec 15, 2020
@ankatare
fixing build issues, incorporated review comments of harvey to exclud…
a9e100c 
…e v2 protos from source code also tracking issue envoyproxy#14197

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 6, 2021
ankatare added a commit to ankatare/envoy that referenced this issue Jan 11, 2021
@ankatare
incorporated review comments and wrote unit test for api_type_oracle,…
9d055be 
… also tracking it with issue as envoyproxy#14197

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

ankatare added a commit to ankatare/envoy that referenced this issue Jan 15, 2021
@ankatare
incorporated review comments and wrote unit test for api_type_oracle,…
7ab40e5 
… also tracking it with issue as envoyproxy#14197

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Contributor Author

@htuch may be this issue can be reopen since it is closed automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankatare ankatare

Labels
api/v2 api/v3 Major version release @ end of Q3 2019 stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ankatare @jmarantz @mattklein123