Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.http1_flood_protection deprecation #13445

Closed
alyssawilk opened this issue Oct 8, 2020 · 0 comments
Closed

envoy.reloadable_features.http1_flood_protection deprecation #13445

alyssawilk opened this issue Oct 8, 2020 · 0 comments
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.17.0

Comments

@alyssawilk
Copy link
Contributor

Your change commit f5b0294 (http: adding response flood protection) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 8, 2020
@alyssawilk alyssawilk self-assigned this Oct 8, 2020
@mattklein123 mattklein123 added this to the 1.17.0 milestone Oct 11, 2020
@alyssawilk alyssawilk mentioned this issue Oct 12, 2020
Merged
htuch pushed a commit that referenced this issue Oct 12, 2020
@alyssawilk
http: removing envoy.reloadable_features.http1_flood_protection (#13508)
b74173b 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes ##13445

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.17.0
Development

No branches or pull requests
2 participants
@mattklein123 @alyssawilk