-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"mode" setting on config.core.v3.Pipe has no apparent effect #11809
Comments
This is potentially a bug. I think in some cases the |
Archive.zip |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions. |
It seems listener[].address.pipe.mode configuration wasn't working under v3 api. Fixes envoyproxy#11809 Signed-off-by: Sorah Fukumori <her@sorah.jp>
This patch fixes the following configuration working as expected. ```yaml static_resources: listeners: - name: http address: pipe: path: '/tmp/envoy.sock' mode: 438 # 0666 # ... ``` Risk Level: Low Testing: added integration test Docs Changes: N/A Release Notes: N/A Fixes: #11809 Signed-off-by: Sorah Fukumori <her@sorah.jp>
This patch fixes the following configuration working as expected. ```yaml static_resources: listeners: - name: http address: pipe: path: '/tmp/envoy.sock' mode: 438 # 0666 # ... ``` Risk Level: Low Testing: added integration test Docs Changes: N/A Release Notes: N/A Fixes: envoyproxy/envoy#11809 Signed-off-by: Sorah Fukumori <her@sorah.jp>
Hello,
We're setting up a Listener to use a unix socket, and are attempting to set the mode of the pipes to (octal) 666. We've set this config on the listener (this is copy/pasted from a config dump via the admin web interface):
However the resulting socket at /run/copilot-http has a mode of 755 (which is umask default):
We are running this inside of the official Envoy container, version 1.14.1. Is there extra config we're missing, or another setting that's overriding the mode of the socket perhaps?
Thank you!
The text was updated successfully, but these errors were encountered: