Skip to content

Commit

Permalink
upstream: delete stale TODO (#8028)
Browse files Browse the repository at this point in the history
This was fixed in #7877

Signed-off-by: Matt Klein <mklein@lyft.com>
  • Loading branch information
mattklein123 authored Aug 23, 2019
1 parent 07e3e28 commit dbb11fd
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions source/common/upstream/upstream_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1311,12 +1311,6 @@ bool BaseDynamicClusterImpl::updateDynamicHostList(const HostVector& new_hosts,

// At this point we've accounted for all the new hosts as well the hosts that previously
// existed in this priority.

// TODO(mattklein123): This stat is used by both the RR and LR load balancer to decide at
// runtime whether to use either the weighted or unweighted mode. If we extend weights to
// static clusters or DNS SRV clusters we need to make sure this gets set. Better, we should
// avoid pivoting on this entirely and probably just force a host set refresh if any weights
// change.
info_->stats().max_host_weight_.set(max_host_weight);

// Whatever remains in current_priority_hosts should be removed.
Expand Down

0 comments on commit dbb11fd

Please sign in to comment.