build: marking extensions as extension-only visible by default

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

bazel/envoy_build_system.bzl

@@ -7,6 +7,7 @@ load(
     ":envoy_library.bzl",
     _envoy_basic_cc_library = "envoy_basic_cc_library",
     _envoy_cc_extension = "envoy_cc_extension",
+    _envoy_cc_extension_library = "envoy_cc_extension_library",
     _envoy_cc_library = "envoy_cc_library",
     _envoy_cc_posix_library = "envoy_cc_posix_library",
     _envoy_cc_win32_library = "envoy_cc_win32_library",
@@ -178,6 +179,7 @@ envoy_cc_binary = _envoy_cc_binary
 envoy_basic_cc_library = _envoy_basic_cc_library
 envoy_cc_extension = _envoy_cc_extension
 envoy_cc_library = _envoy_cc_library
+envoy_cc_extension_library = _envoy_cc_extension_library
 envoy_cc_posix_library = _envoy_cc_posix_library
 envoy_cc_win32_library = _envoy_cc_win32_library
 envoy_include_prefix = _envoy_include_prefix

bazel/envoy_library.bzl

@@ -77,6 +77,34 @@ def envoy_cc_extension(
         fail("Unknown extension status: " + status)
     envoy_cc_library(name, tags = tags, **kwargs)
 
+def envoy_cc_extension_library(
+        name,
+        srcs = [],
+        hdrs = [],
+        copts = [],
+        visibility = ["//source/extensions:__subpackages__", "//test/extensions:__subpackages__"],
+        external_deps = [],
+        tcmalloc_dep = None,
+        repository = "",
+        tags = [],
+        deps = [],
+        strip_include_prefix = None,
+        textual_hdrs = None):
+    envoy_cc_library(
+        name = name,
+        srcs = srcs,
+        hdrs = hdrs,
+        copts = copts,
+        visibility = visibility,
+        external_deps = external_deps,
+        tcmalloc_dep = tcmalloc_dep,
+        repository = repository,
+        tags = tags,
+        deps = deps,
+        strip_include_prefix = strip_include_prefix,
+        textual_hdrs = textual_hdrs,
+    )
+
 # Envoy C++ library targets should be specified with this function.
 def envoy_cc_library(
         name,

source/extensions/access_loggers/BUILD

@@ -1,16 +1,18 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "well_known_names",
     hdrs = ["well_known_names.h"],
+    # well known names files are public as long as they exist.
+    visibility = ["//visibility:public"],
     deps = [
         "//source/common/singleton:const_singleton",
     ],

source/extensions/access_loggers/common/BUILD

@@ -1,6 +1,6 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
@@ -10,7 +10,7 @@ licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "access_log_base",
     srcs = ["access_log_base.cc"],
     hdrs = ["access_log_base.h"],

source/extensions/access_loggers/file/BUILD

@@ -1,7 +1,7 @@
 load(
     "//bazel:envoy_build_system.bzl",
     "envoy_cc_extension",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
@@ -12,10 +12,12 @@ licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "file_access_log_lib",
     srcs = ["file_access_log_impl.cc"],
     hdrs = ["file_access_log_impl.h"],
+    # The file based access logger is core code.
+    visibility = ["//visibility:public"],
     deps = [
         "//source/extensions/access_loggers/common:access_log_base",
     ],

source/extensions/access_loggers/grpc/BUILD

@@ -1,7 +1,7 @@
 load(
     "//bazel:envoy_build_system.bzl",
     "envoy_cc_extension",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
@@ -12,7 +12,7 @@ licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "config_utils",
     srcs = ["config_utils.cc"],
     hdrs = ["config_utils.h"],
@@ -24,7 +24,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "grpc_access_log_lib",
     srcs = ["grpc_access_log_impl.cc"],
     hdrs = ["grpc_access_log_impl.h"],
@@ -44,7 +44,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "grpc_access_log_utils",
     srcs = ["grpc_access_log_utils.cc"],
     hdrs = ["grpc_access_log_utils.h"],
@@ -58,7 +58,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "http_grpc_access_log_lib",
     srcs = ["http_grpc_access_log_impl.cc"],
     hdrs = ["http_grpc_access_log_impl.h"],
@@ -71,7 +71,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "tcp_grpc_access_log_lib",
     srcs = ["tcp_grpc_access_log_impl.cc"],
     hdrs = ["tcp_grpc_access_log_impl.h"],
@@ -83,7 +83,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "grpc_access_log_proto_descriptors_lib",
     srcs = ["grpc_access_log_proto_descriptors.cc"],
     hdrs = ["grpc_access_log_proto_descriptors.h"],

source/extensions/clusters/BUILD

@@ -1,16 +1,18 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "well_known_names",
     hdrs = ["well_known_names.h"],
+    # well known names files are public as long as they exist.
+    visibility = ["//visibility:public"],
     deps = [
         "//source/common/config:well_known_names",
         "//source/common/singleton:const_singleton",

source/extensions/clusters/redis/BUILD

@@ -1,23 +1,23 @@
 load(
     "//bazel:envoy_build_system.bzl",
     "envoy_cc_extension",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "crc16_lib",
     srcs = [
         "crc16.cc",
         "crc16.h",
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "redis_cluster_lb",
     srcs = [
         "redis_cluster_lb.cc",

source/extensions/common/BUILD

@@ -1,16 +1,18 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "utility_lib",
     hdrs = ["utility.h"],
+    # Legacy.  TODO(#9953) clean up.
+    visibility = ["//visibility:public"],
     deps = [
         "//include/envoy/runtime:runtime_interface",
         "//source/common/common:documentation_url_lib",

source/extensions/common/aws/BUILD

@@ -1,22 +1,22 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "signer_interface",
     hdrs = ["signer.h"],
     deps = [
         "//include/envoy/http:message_interface",
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "signer_impl_lib",
     srcs = ["signer_impl.cc"],
     hdrs = ["signer_impl.h"],
@@ -35,13 +35,13 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "credentials_provider_interface",
     hdrs = ["credentials_provider.h"],
     external_deps = ["abseil_optional"],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "credentials_provider_impl_lib",
     srcs = ["credentials_provider_impl.cc"],
     hdrs = ["credentials_provider_impl.h"],
@@ -56,7 +56,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "utility_lib",
     srcs = ["utility.cc"],
     hdrs = ["utility.h"],
@@ -67,13 +67,13 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "region_provider_interface",
     hdrs = ["region_provider.h"],
     external_deps = ["abseil_optional"],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "region_provider_impl_lib",
     srcs = ["region_provider_impl.cc"],
     hdrs = ["region_provider_impl.h"],

source/extensions/common/dynamic_forward_proxy/BUILD

@@ -1,14 +1,14 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "dns_cache_interface",
     hdrs = ["dns_cache.h"],
     deps = [
@@ -22,7 +22,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "dns_cache_manager_impl",
     srcs = ["dns_cache_manager_impl.cc"],
     hdrs = ["dns_cache_manager_impl.h"],
@@ -33,7 +33,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "dns_cache_impl",
     srcs = ["dns_cache_impl.cc"],
     hdrs = ["dns_cache_impl.h"],
@@ -50,7 +50,7 @@ envoy_cc_library(
     ],
 )
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "dns_cache_resource_manager",
     srcs = ["dns_cache_resource_manager.cc"],
     hdrs = ["dns_cache_resource_manager.h"],

source/extensions/common/proxy_protocol/BUILD

@@ -1,17 +1,19 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_library",
+    "envoy_cc_extension_library",
     "envoy_package",
 )
 
 licenses(["notice"])  # Apache 2
 
 envoy_package()
 
-envoy_cc_library(
+envoy_cc_extension_library(
     name = "proxy_protocol_header_lib",
     srcs = ["proxy_protocol_header.cc"],
     hdrs = ["proxy_protocol_header.h"],
+    # This is used by the router, so considered core code.
+    visibility = ["//visibility:public"],
     deps = [
         "//include/envoy/buffer:buffer_interface",
         "//include/envoy/network:address_interface",