ci: add jobs for building iOS demo apps (#373)

Adds 2 new jobs that build the Swift and Objective-C demo apps on CI.

Note that the `Envoy.framework` artifact has to be zipped during upload and unzipped during download since the upload/download GitHub actions seem to use the _contents_ of `Envoy.framework` instead of the whole folder (and thus incorrectly end up with the contents of `Envoy.framework` in `dist/` after downloading instead of an `Envoy.framework`).

These will be used to validate that the demos continue to work properly.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>

mobile/.github/workflows/ios.yml

@@ -3,24 +3,45 @@ name: ios
 on: [push]
 
 jobs:
-  # TODO: need to add back objc demo once https://github.com/lyft/envoy-mobile/issues/230
-  # is closed.
   macdist:
     name: mac_dist
     runs-on: macOS-10.14
+    timeout-minutes: 45
     steps:
       - uses: actions/checkout@v1
         with:
           submodules: true
       - name: 'Install dependencies'
         run: ./ci/mac_ci_setup.sh
       - name: 'Build Envoy.framework distributable'
-        run: |
-          ./bazelw build --config=ios //:ios_dist
-      - run: ./bazelw build --config=ios //examples/swift/hello_world:app
-        name: 'Build swift app'
+        run: ./bazelw build --config=ios //:ios_dist
+      - name: 'Zip Envoy.framework.zip distributable'
+        run: zip -r dist/Envoy.framework.zip dist/Envoy.framework
+      - run: ls -lh dist/
+      - uses: actions/upload-artifact@v1
+        with:
+          name: Envoy.framework.zip
+          path: dist/Envoy.framework.zip
+  macswift:
+    name: mac_swift_helloworld
+    needs: macdist
+    runs-on: macOS-10.14
+    timeout-minutes: 45
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - name: 'Install dependencies'
+        run: ./ci/mac_ci_setup.sh
+      - uses: actions/download-artifact@v1
+        with:
+          name: Envoy.framework.zip
+          path: dist/
+      - run: unzip dist/Envoy.framework.zip
+      - run: ls -lh dist/
+      - name: 'Build swift app'
+        run: ./bazelw build --config=ios //examples/swift/hello_world:app
       # TODO: re-enable liveliness test.
-      # TODO: re-enable objc app once https://github.com/lyft/envoy-mobile/issues/230 closes.
       # - run: npm install -g ios-sim && ios-sim start --devicetypeid "iPhone-X, 12.2"
       #   name: 'Start the iOS simulator'
       # # Run the app in the background and redirect logs.
@@ -32,6 +53,26 @@ jobs:
       # # Check for the sentinel value that shows the app is alive and well.
       # - run: cat /tmp/envoy.log | grep 'Hello, world!'
       #   name: 'Check liveliness'
+  macobjc:
+    name: mac_objc_helloworld
+    needs: macdist
+    runs-on: macOS-10.14
+    timeout-minutes: 45
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - name: 'Install dependencies'
+        run: ./ci/mac_ci_setup.sh
+      - uses: actions/download-artifact@v1
+        with:
+          name: Envoy.framework.zip
+          path: dist/
+      - run: unzip dist/Envoy.framework.zip
+      - run: ls -lh dist/
+      - name: 'Build objective-c app'
+        run: ./bazelw build --config=ios //examples/objective-c/hello_world:app
+      # TODO: re-enable liveliness test (same as swift).
   swifttests:
     name: swift_tests
     runs-on: macOS-10.14