Update the comment about the rejected resources

Signed-off-by: Lidi Zheng <lidiz@google.com>
envoyproxy · Jan 14, 2021 · a906bf3 · a906bf3
1 parent 7488ac3
commit a906bf3
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/api/envoy/admin/v3/config_dump.proto b/api/envoy/admin/v3/config_dump.proto
@@ -49,8 +49,9 @@ message UpdateFailureState {
       "envoy.admin.v2alpha.UpdateFailureState";
 
   // What the component configuration would have been if the update had succeeded.
-  // This field may not be present on certain implementation of xDS client or
-  // server due to concerns of overhead.
+  // This field may not be populated by xDS clients due to storage overhead. As
+  // for xDS servers, they may only keep and dump the latest config regardless
+  // it is accepted or rejected.
   google.protobuf.Any failed_configuration = 1;
 
   // Time of the latest failed update attempt.

diff --git a/api/envoy/admin/v4alpha/config_dump.proto b/api/envoy/admin/v4alpha/config_dump.proto
diff --git a/generated_api_shadow/envoy/admin/v3/config_dump.proto b/generated_api_shadow/envoy/admin/v3/config_dump.proto
diff --git a/generated_api_shadow/envoy/admin/v4alpha/config_dump.proto b/generated_api_shadow/envoy/admin/v4alpha/config_dump.proto