rate_limit: Add time unit month and year (#24070)

Signed-off-by: tyxia <tyxia@google.com>
envoyproxy · Nov 21, 2022 · 8a26244 · 8a26244
1 parent b5e3ec9
commit 8a26244
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/api/envoy/service/ratelimit/v3/rls.proto b/api/envoy/service/ratelimit/v3/rls.proto
@@ -92,6 +92,12 @@ message RateLimitResponse {
 
       // The time unit representing a day.
       DAY = 4;
+
+      // The time unit representing a month.
+      MONTH = 5;
+
+      // The time unit representing a year.
+      YEAR = 6;
     }
 
     // A name or description of this limit.

diff --git a/changelogs/current.yaml b/changelogs/current.yaml
@@ -29,6 +29,9 @@ minor_behavior_changes:
 - area: oauth2
   change: |
     Requests which match the passthrough header now have their own metric ``oauth_passthrough`` and aren't included in ``oauth_success`` anymore.
+- area: rate_limit
+  change: |
+    add ``MONTH`` and ``YEAR`` to the unit of time for rate limit.
 
 bug_fixes:
 # *Changes expected to improve the state of the world and are unlikely to have negative effects*

diff --git a/source/extensions/filters/http/ratelimit/ratelimit_headers.cc b/source/extensions/filters/http/ratelimit/ratelimit_headers.cc
@@ -75,6 +75,10 @@ uint32_t XRateLimitHeaderUtils::convertRateLimitUnit(
     return 60 * 60;
   case envoy::service::ratelimit::v3::RateLimitResponse::RateLimit::DAY:
     return 24 * 60 * 60;
+  case envoy::service::ratelimit::v3::RateLimitResponse::RateLimit::MONTH:
+    return 30 * 24 * 60 * 60;
+  case envoy::service::ratelimit::v3::RateLimitResponse::RateLimit::YEAR:
+    return 365 * 24 * 60 * 60;
   case envoy::service::ratelimit::v3::RateLimitResponse::RateLimit::UNKNOWN:
   default:
     return 0;