Skip to content

Commit

Permalink
Updated comments.
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
  • Loading branch information
KBaichoo committed Jan 12, 2021
1 parent 0fe46db commit 3f8ba3e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions include/envoy/server/fatal_action_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ class FatalAction {
public:
virtual ~FatalAction() = default;
/**
* Callback function to run when we are crashing.
* @param objects a vector of objects we were working on when we started crashing.
* Callback function to run when Envoy is crashing.
* @param tracked_objects a span of objects Envoy was working on when Envoy started crashing.
*/
virtual void run(absl::Span<const ScopeTrackedObject* const> tracked_objects) PURE;

Expand Down
2 changes: 1 addition & 1 deletion source/common/common/scope_tracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace Envoy {

// A small class for tracking the managing the scope of a tracked object which is currently having
// A small class for managing the scope of a tracked object which is currently having
// work done in this thread.
//
// When created, it appends the tracked object to the dispatcher's stack of tracked objects, and
Expand Down
6 changes: 3 additions & 3 deletions source/common/event/dispatcher_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
namespace Envoy {
namespace Event {
namespace {
// Our tracked object stack likely won't grow larger than this initial
// reservation; this should make appends constant time since we shouldn't
// have to grow the stack larger.
// The tracked object stack likely won't grow larger than this initial
// reservation; this should make appends constant time since the stack
// shouldn't have to grow larger.
constexpr size_t ExpectedMaxTrackedObjectStackDepth = 10;
} // namespace

Expand Down

0 comments on commit 3f8ba3e

Please sign in to comment.