trace level and delete assert nullptr before use

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
envoyproxy · Feb 23, 2021 · 171b6d4 · 171b6d4
1 parent 2d603b8
commit 171b6d4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/source/common/config/grpc_stream.h b/source/common/config/grpc_stream.h
@@ -72,8 +72,6 @@ class GrpcStream : public Grpc::AsyncStreamCallbacks<ResponseProto>,
   bool grpcStreamAvailable() const { return stream_ != nullptr; }
 
   void sendMessage(const RequestProto& request) {
-    ASSERT(stream_ != nullptr, absl::StrCat("sending message to invalid grpc stream for method ",
-                                            service_method_.DebugString()));
     stream_->sendMessage(request, false);
   }
 

diff --git a/source/common/event/dispatcher_impl.cc b/source/common/event/dispatcher_impl.cc
@@ -325,7 +325,7 @@ void DispatcherImpl::shutdown() {
   ASSERT(!shutdown_called_);
   shutdown_called_ = true;
   ENVOY_LOG(
-      debug,
+      trace,
       "{} destroyed {} thread local objects. Peek {} deferred deletables, {} post callbacks. ",
       __FUNCTION__, deferred_deletables_size, post_callbacks_size, thread_local_deletables_size);
 }

diff --git a/source/common/upstream/upstream_impl.cc b/source/common/upstream/upstream_impl.cc
@@ -929,7 +929,7 @@ ClusterImplBase::ClusterImplBase(
                           std::move(socket_matcher), std::move(stats_scope), added_via_api,
                           factory_context),
       [&dispatcher](const ClusterInfoImpl* self) {
-        ENVOY_LOG(debug, "Schedule destroy cluster info {}", self->name());
+        ENVOY_LOG(trace, "Schedule destroy cluster info {}", self->name());
         dispatcher.deleteInDispatcherThread(
             std::unique_ptr<const Event::DispatcherThreadDeletable>(self));
       });