Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated: delete envoy_stream_options #643

Closed
junr03 opened this issue Jan 24, 2020 · 1 comment · Fixed by #689
Closed

deprecated: delete envoy_stream_options #643

junr03 opened this issue Jan 24, 2020 · 1 comment · Fixed by #689
Assignees
@rebello95
Labels
core

Comments

@junr03
Copy link
Member

junr03 commented Jan 24, 2020

stream options was added in order to configure buffering for retries. This was required when the direct API leveraged the AsyncClient. However, after #616 the option is no longer needed as the Router uses the configured retry policy in the route/and or headers in the stream to determine if retries are enabled and thus if body data has to be buffered.

After #616 merges envoy_stream_options can be removed. Note, for Lyft, that this is a breaking API change so the Apps function calls will have to be updated when the parameter is removed.
@junr03 junr03 added the core label Jan 24, 2020
@junr03 junr03 self-assigned this Jan 24, 2020
@junr03 junr03 mentioned this issue Jan 24, 2020
Merged
@rebello95 rebello95 assigned rebello95 and unassigned junr03 Feb 14, 2020
rebello95 added a commit that referenced this issue Feb 14, 2020
@rebello95
core: remove envoy_stream_options
0b1a8fa 
As of #616, this is no longer used or necessary since it's handled by the router.

Resolves #643.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95 rebello95 mentioned this issue Feb 14, 2020
Merged
@rebello95
Copy link
Contributor

#689

rebello95 added a commit that referenced this issue Feb 19, 2020
@rebello95
core: remove envoy_stream_options (#689)
2223fcc 
As of #616, this is no longer used or necessary since it's handled by the router.

Resolves #643.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@rebello95 @jpsim
core: remove envoy_stream_options (#689)
3549a96 
As of envoyproxy/envoy-mobile#616, this is no longer used or necessary since it's handled by the router.

Resolves envoyproxy/envoy-mobile#643.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@rebello95 @jpsim
core: remove envoy_stream_options (#689)
44c4365 
As of envoyproxy/envoy-mobile#616, this is no longer used or necessary since it's handled by the router.

Resolves envoyproxy/envoy-mobile#643.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebello95 rebello95

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: remove envoy_stream_options envoyproxy/envoy-mobile
2 participants
@rebello95 @junr03