Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support dynamic_forward_proxy #433

Closed
rebello95 opened this issue Sep 12, 2019 · 1 comment
Closed

config: support dynamic_forward_proxy #433

rebello95 opened this issue Sep 12, 2019 · 1 comment
Assignees

Comments

@rebello95
Copy link
Contributor

We currently have a dynamic_forward_proxy configuration in the base config file that's checked in to the repo, but it doesn't function when using the direct API (and the base cluster must be used with a hardcoded domain for now).

We'll need to support the dynamic_forward_proxy configuration so consumers don't need to pre-define acceptable domains for routing when creating Envoy instances.

@rebello95 rebello95 added this to the v0.3 "Secondi" milestone Sep 12, 2019
rebello95 added a commit that referenced this issue Sep 12, 2019
Adds support for setting the domain used in the base cluster of the Envoy config. This is necessary until `dynamic_forward_proxy` is working (see #433).

Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95 added a commit that referenced this issue Sep 12, 2019
Adds support for setting the domain used in the base cluster of the Envoy config. This is necessary until `dynamic_forward_proxy` is working (see #433).

Android change will come in a follow-up PR.

Risk Level: Low
Testing: Locally on demos & unit tests

Signed-off-by: Michael Rebello <me@michaelrebello.com>
@junr03
Copy link
Member

junr03 commented Feb 4, 2020

fixed by #616

@junr03 junr03 closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants