objc: fix lib rule to include necessary header #230
Comments
junr03
pushed a commit
that referenced
this issue
Jul 8, 2019
Co-authored-by: Keith Smiley keithbsmiley@gmail.com Signed-off-by: Mike Schore mike.schore@gmail.com Description: We've decided to implement our public and platform-specific library layer primarily in Swift on iOS. Migrating to this has some repercussions for the build and for the time-being will require custom Bazel rules to compose the distributable static framework. This PR migrates the code to swift and introduces the build rules required. Note: this PR breaks objective-c. This is known and an issue has been filed #230. Risk Level: Medium - moves pieces of the library to swift, and introduces new build rules. Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com>
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions. |
|
I've opened a couple related issues, bazelbuild/rules_swift#291 and bazelbuild/rules_apple#557. Neither of these are blocking this issue, but they'd be helpful. cc @rebello95 |
|
Thanks so much for your help with this @kastiglione. |
rebello95
added a commit
that referenced
this issue
Aug 22, 2019
This updates our static framework rule to properly copy the `-Swift.h` header file from the bazel output directory into our final `Envoy.framework/Headers/Envoy-Swift.h`. There are a few workarounds here for issues that @kastiglione has been nice enough to file upstream: **bazelbuild/rules_swift#291 The code required to find and copy the `-Swift.h` header file could be simplified with this issue. **bazelbuild/rules_apple#557 From the Objective-C demo app, we also depend on an empty Swift library to force dependencies like `swiftFoundation` to link. Resolves #230 Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this issue
Nov 28, 2022
This updates our static framework rule to properly copy the `-Swift.h` header file from the bazel output directory into our final `Envoy.framework/Headers/Envoy-Swift.h`. There are a few workarounds here for issues that @kastiglione has been nice enough to file upstream: **bazelbuild/rules_swift#291 The code required to find and copy the `-Swift.h` header file could be simplified with this issue. **bazelbuild/rules_apple#557 From the Objective-C demo app, we also depend on an empty Swift library to force dependencies like `swiftFoundation` to link. Resolves envoyproxy/envoy-mobile#230 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this issue
Nov 29, 2022
This updates our static framework rule to properly copy the `-Swift.h` header file from the bazel output directory into our final `Envoy.framework/Headers/Envoy-Swift.h`. There are a few workarounds here for issues that @kastiglione has been nice enough to file upstream: **bazelbuild/rules_swift#291 The code required to find and copy the `-Swift.h` header file could be simplified with this issue. **bazelbuild/rules_apple#557 From the Objective-C demo app, we also depend on an empty Swift library to force dependencies like `swiftFoundation` to link. Resolves envoyproxy/envoy-mobile#230 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#188 migrated the library layer to swift. It needed a lot of complex bazel work to support the design we had adopted. In the way we broke the objective-c demo, as a necessary header is not included in the static framework.
@goaway understands the problem and will fix as expediently as possible.
The text was updated successfully, but these errors were encountered: