2023-01 Maintenance #282
Merged
2023-01 Maintenance #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated: https://github.com/xwp/wp-dev-lib And travis ci hasn't worked in years.
We don't have the txt -> md converter any more because dev-lib is deprecated. I can't find a suitable replacement right now so we'll just keep both files editable.
ncu -u && npm install
jscs is deprecated and rolled into eslint Lets swap to eslint to match our other projects
satooshi/php-coveralls has been replaced with php-coveralls/php-coveralls
We'll use these for tests
blimpage
reviewed
Jan 17, 2023
| 'type' => 'percent', | ||
| 'number' => $theme['rating']['count'], | ||
| 'number' => $count, |
There was a problem hiding this comment.
Should this bug fix be mentioned in the changelogs too?
blimpage
reviewed
Jan 17, 2023
languages/envato-market.pot
Outdated
| #: docs/dist/envato-market/inc/class-envato-market-items.php:100 | ||
| #: docs/dist/envato-market/inc/class-envato-market-items.php:110 | ||
| #: docs/dist/envato-market/inc/class-envato-market.php:149 | ||
| #: docs/dist/envato-market/inc/class-envato-market.php:159 |
There was a problem hiding this comment.
There are lots of new inclusions from docs/dist/ in here, are they meant to be included in this file?
There was a problem hiding this comment.
Ah never mind, you've already removed them 😄
There was a problem hiding this comment.
Yes this was a mistake, I removed those exclude options trying to get the updated makepot tool working. Forgot to bring them back.
They're back now and those entries shouldn't make it into the potfile any more: 5a60d80
Re: 4bda021 Co-authored-by: Pat McKenna <pat@mckenna.rocks>
blimpage
approved these changes
Jan 17, 2023
I accidentally removed this section while trying to get it working again. We need this otherwise it can bring in unwanted translations in the pot file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes