Fix exiv2 0.28 compatibility #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmf documentation claims that pkg_config will try exiv2-config and then pkg-config, but that's not true. At least in version 3.1.3, only exiv2-config is searched for. Since exiv2 doesn't generate its own wrapper, force pkg-config instead.
Also remove the unused / not working flags from MAKEFILE_CONFIG.
petervandoros
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow compiling with versions both < 0.27 and >= 0.28.
Ensure that if the library is configured with libssh and/or libcurl, we include those in the compilation as well.
Closes #29