Revert "Limit the search window to 24 hours"

This reverts commit 0beef77.
entur · Aug 24, 2023 · 179ef19 · 179ef19
1 parent 274bace
commit 179ef19
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/src/ext/graphql/transmodelapi/schema.graphql b/src/ext/graphql/transmodelapi/schema.graphql
@@ -834,7 +834,7 @@ type QueryType {
     """
     relaxTransitSearchGeneralizedCostAtDestination: Float = null,
     """
-    The length of the search-window in minutes. This parameter is optional. The maximum value is 1440 minutes (24 hours).
+    The length of the search-window in minutes. This parameter is optional.
     
     The search-window is defined as the duration between the earliest-departure-time(EDT) and the latest-departure-time(LDT). OTP will search for all itineraries in this departure window. If `arriveBy=true` the `dateTime` parameter is the latest-arrival-time, so OTP will dynamically calculate the EDT. Using a short search-window is faster than using a longer one, but the search duration is not linear. Using a "too" short search-window will waste resources server side, while using a search-window that is too long will be slow.
     

diff --git a/src/ext/java/org/opentripplanner/ext/transmodelapi/model/plan/TripQuery.java b/src/ext/java/org/opentripplanner/ext/transmodelapi/model/plan/TripQuery.java
@@ -61,8 +61,7 @@ public static GraphQLFieldDefinition create(
           .newArgument()
           .name("searchWindow")
           .description(
-            "The length of the search-window in minutes. This parameter is optional. " +
-            "The maximum value is 1440 minutes (24 hours)." +
+            "The length of the search-window in minutes. This parameter is optional." +
             "\n\n" +
             "The search-window is defined as the duration between the earliest-departure-time(EDT) and " +
             "the latest-departure-time(LDT). OTP will search for all itineraries in this departure " +

diff --git a/src/main/java/org/opentripplanner/routing/api/request/RouteRequest.java b/src/main/java/org/opentripplanner/routing/api/request/RouteRequest.java
@@ -12,7 +12,6 @@
 import java.util.Locale;
 import java.util.function.Consumer;
 import org.opentripplanner.framework.time.DateUtils;
-import org.opentripplanner.framework.time.TimeUtils;
 import org.opentripplanner.model.GenericLocation;
 import org.opentripplanner.model.plan.SortOrder;
 import org.opentripplanner.model.plan.pagecursor.PageCursor;
@@ -320,9 +319,6 @@ public Duration searchWindow() {
   }
 
   public void setSearchWindow(Duration searchWindow) {
-    if (searchWindow != null && searchWindow.toSeconds() > TimeUtils.ONE_DAY_SECONDS) {
-      throw new IllegalArgumentException("The search window cannot exceed 24 hours");
-    }
     this.searchWindow = searchWindow;
   }