Frankie/core#v0.3.0.rc 1 #421
Conversation
This command makes it possible to use files located in the `./dev` directory from within the Docker containers, enabling the option of loading a custom chain spec file for testing.
dev/bin/ENTROPY_CORE_VERSION.sh
Outdated
| @@ -1,3 +1,3 @@ | |||
| #! /usr/bin/env bash | |||
|
|
|||
| export ENTROPY_CORE_VERSION=release-v0.2.0 | |||
| export ENTROPY_CORE_VERSION=release-v0.3.0-rc.1 | |||
There was a problem hiding this comment.
| export ENTROPY_CORE_VERSION=release-v0.3.0-rc.1 | |
| export ENTROPY_CORE_VERSION=release-v0.3.0 |
| # commit in the `entropy-core` repository. Refer to the wiki page at | ||
| # https://github.com/entropyxyz/meta/wiki/Git#conventions for details | ||
| # about how Git tags, branches, and commits refer to image tags here. | ||
| image: entropyxyz/entropy-tss:${ENTROPY_CORE_VERSION:-latest} |
There was a problem hiding this comment.
🔥 I don't know if we want this to default to latest do we?
I 100% want to know what the version is I'm running and if I forgot to set the ENTROPY_CORE_VERSION this feels like I'm gonna get some random surprise version 👎
There was a problem hiding this comment.
this -latest came as a suggestion from @vitropy i believe i am hestant to remove this as i want to get the latest build for this version tag that i am asking for
There was a problem hiding this comment.
@mixmix I think @frankiebee is correct here: if you 100% want to know what the version you are running is, simply set ENTROPY_CORE_VERSION in your environment. That is what this variable is for. See Environment variables in our Wiki. If you don't set it, then getting the latest tag mimics the behavior of all other Docker default commands, which is what 99% of users are going to want.
There was a problem hiding this comment.
Yes I get this is a fallback. I just think it might be a foot-gun. Fine to wait and see though!
There was a problem hiding this comment.
lets wait and see
…tarting. otherwise jumpstart never resolves
…into frankie/core#v0.3.0.rc-1
…into frankie/core#v0.3.0.rc-1
This PR updates to the latest version of core (still in rc)