Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NayNay] Signing Fix: Message too long error #412

Merged
merged 4 commits into from
Aug 26, 2024
Merged

[NayNay] Signing Fix: Message too long error #412

merged 4 commits into from
Aug 26, 2024

Conversation

rh0delta
Copy link
Contributor

Related Issue(s)

Proposed Changes

  • update picking validators to use BigInt instead of regular parseInt

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Screenshot 2024-08-19 at 11 49 04 PM

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have commented my code.
  • I have updated documentation, where necessary.

@rh0delta
[NayNay] Signing Fix: Message too long error
0044df2 
- update picking validators to use BigInt instead of regular parseInt
frankiebee
frankiebee requested changes Aug 20, 2024
View reviewed changes
src/signing/index.ts Outdated Show resolved Hide resolved
@frankiebee
Copy link
Collaborator

where the tests at?

@rh0delta
Copy link
Contributor Author

@frankiebee Ive updated the index calc, and added tests. Ready for re-review!

mixmix
mixmix reviewed Aug 21, 2024
View reviewed changes
src/signing/index.ts Outdated Show resolved Hide resolved
mixmix
mixmix reviewed Aug 21, 2024
View reviewed changes
src/signing/index.ts Outdated Show resolved Hide resolved
mixmix
mixmix previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!
🌶️ Did you check to see that it failed before you applied your fix?

Please merge those suggestions which simplify the code then merge PR.

rh0delta and others added 2 commits August 26, 2024 14:19
@rh0delta @mixmix
Update src/signing/index.ts
e2f81b8 
Co-authored-by: mix irving <mix@protozoa.nz>
@rh0delta @mixmix
Update src/signing/index.ts
4ced232 
Co-authored-by: mix irving <mix@protozoa.nz>
frankiebee
frankiebee approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop woop 👍

@frankiebee frankiebee merged commit dae4cb0 into main Aug 26, 2024
3 checks passed
@frankiebee frankiebee deleted the naynay/signing-msg-length branch August 26, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankiebee frankiebee frankiebee approved these changes

@mixmix mixmix Awaiting requested review from mixmix mixmix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

picking validators fails with long strings
3 participants
@rh0delta @frankiebee @mixmix