Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] 🔥 core issue #890 needs to be addressed in sdk 🔥 #380

Closed
frankiebee opened this issue Jun 14, 2024 · 1 comment · Fixed by #390
Closed

[P0] 🔥 core issue #890 needs to be addressed in sdk 🔥 #380

frankiebee opened this issue Jun 14, 2024 · 1 comment · Fixed by #390
Assignees
Labels
P0 HIGH PRIORITY🔥

Comments

@frankiebee
Copy link
Collaborator

frankiebee commented Jun 14, 2024

An issue was misunderstood involving entropy-core issue #890 and a fix was attempted in the cli. The true fix needs to happen in the sdk.
This will require a hot-fix patch into cli.

Closing this issue should require preserving the original subgroup list and reversing this order.
Gotch-yas: i will not be requiring a full test suite to close this issue since their are to many places this could go wrong.

  • The math could be a NaN how do we pick an index from their. Do we throw an error? one could throw an error but their isnt really anything the user could do to fix this error 😢 other then try again (i guess?)
  • The subgroups could be reorder in transit (i.e; polkadot-js or substrate pulling from storage and formating on it's way to/threw rpc) but we wont know that till we try to sign.
  • it's not happening on every signature which might suggest the math for picking index but really thats a recursive thought.

Conclusion try to resubmit once in reverse
if it throws again throw error with the chosen index

@frankiebee frankiebee added the P0 HIGH PRIORITY🔥 label Jun 14, 2024
@frankiebee frankiebee self-assigned this Jun 14, 2024
@frankiebee
Copy link
Collaborator Author

seen in the wild here: https://discord.com/channels/852509982582767677/852509983085690912/1250819152613212234

that first error is a misunderstanding of the problem in the cli

This was referenced Jun 14, 2024
rh0delta pushed a commit that referenced this issue Jun 21, 2024
* wip: puting a pause on retring to adress test harness setup for reproduction of bug

* initial attempt at hox fix

* Test hot fix
rh0delta added a commit that referenced this issue Jul 11, 2024
## [0.2.2] Bathala - 2024-07-11 (entropy-core compatibility: 0.2.0)

### Added
- now exports utils [395](#395)
- now exports testing environments from /dev
[393](https://github.com/entropyxyz/sdk/pull/393/files)
### Fixed
- hot fix for issue #380: try in reverse order for testnet environment
- `entropy.signingManager.getTimeStamp` ->
`entropy.signingManager.getBlockNumber` signature request no longer
takes a time stamp and now takes a block number.
[396](#396)

### Changed
- constructor now throws if you pass no object
- sign now takes a verifying key
[382](#382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 HIGH PRIORITY🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant