-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austin retreat #99
Merged
Merged
Austin retreat #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add input to register() - change account_registration() to register()
- add OCWMessage to crypto/common and use that in the noes - relayer::post() sends only 1 message, not messages
* setup clap CLI * keygen async setup from Clap * keygen async * typechecks pass * yoink, structopt * reorg subdirs * sm-manager * keygen + signing - compilation errors * pending keygen ownership bug * async ownership bugfix
Crypto testnet
update README.md
JesseAbram
commented
Feb 28, 2022
JesseAbram
commented
Feb 28, 2022
JesseAbram
commented
Feb 28, 2022
thor314
previously approved these changes
Mar 1, 2022
- Design change: The communication manager is now always running instead of being called when necessary.
davfra
previously requested changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following README.md section 'testnet'... ./target/release/test_register
throws an error for me.
I think we should relolve this before merging.
thor314
approved these changes
Mar 1, 2022
fjarri
pushed a commit
that referenced
this pull request
May 5, 2023
* init protocol repo commit * block: Zeroize compile bug * resolve zeroize-derive dependency issue * skeleton: keygen and signing * WIP: add extrinsic to user::send_tx() * add comments * ' add comment' * update subxt * add common package * change relayer from lindell17 to common * add conditional std attribute to common * close #68 - change module common to package module * add send_registration(), struct SigRequest * close #72 * Delete etp-lindell17 directory * WIP: testing extrinsics * pallet relayer: unify account_registration and register() - add input to register() - change account_registration() to register() * add testing-user-clients to call extrincics in CLI * mess with node to signing-client communication - add OCWMessage to crypto/common and use that in the noes - relayer::post() sends only 1 message, not messages * Crypto protospec (#84) * setup clap CLI * keygen async setup from Clap * keygen async * typechecks pass * yoink, structopt * reorg subdirs * sm-manager * keygen + signing - compilation errors * pending keygen ownership bug * async ownership bugfix * fix signing-client decoding * minor changes * fix last merge: refactor protocol::user * move common.rs into its own package * add SigResponse to relayer::events::TransactionPropagated * store json key (#88) * store json key * refactor * to do fix * add wait_for_finalized_success() to request_sig_gen() - when receiving a result, result.find_first_event requires wait_for_finalized_success() - request_sig_gen() returns SigResponse * Crypto protospec (#89) * setup clap CLI * keygen async setup from Clap * keygen async * typechecks pass * yoink, structopt * reorg subdirs * sm-manager * keygen + signing - compilation errors * pending keygen ownership bug * async ownership bugfix * blocking: handling error on 6 of 7 keygen * keygen bug documented * Store keys (#90) * store json key * refactor * to do fix * alice send * add sign_message() to User * cli separated * cli separated (#92) * add fn sign_message() and a test to run it * integration * add scripts to run 2 signing-clients locally * work on registration * fix scripts/alice.sh and scripts/bob.sh * add send() to registration * remove main.rs in alice-send * unbreak wrap cli * registration complete * user await sign() * add gg20-sm-manager's routines to signing-client * fix sm-manager in signing-client * add println!() for debugging * copy local-share1.json to root - this key needs to be in the root for the current testnet setup - the other key local-share2.json is copied to root in the User registration * change Rocket.toml settings * - add logs * adjust signing-client for node1 * change order of SignCli::sign_cli.parties - changed from vec![1,2] to vec![2,1] - THIS made the signature generation possible. WHY? - change for user and signing-node * add testnet instructions to README.md * update README.md * comment changes * tests * fmt * todo * event docs * pipeline * update README.md * remove start_com_manager() - Design change: The communication manager is now always running instead of being called when necessary. * remove unused code * build fix * fix non compilation * fmt * build fix Co-authored-by: Thor <thorck@protonmail.com> Co-authored-by: davfra <64629389davfra@users.noreply.github.com> Co-authored-by: David <818daf@gmail.com> Co-authored-by: Thor <7041313+thor314@users.noreply.github.com> Co-authored-by: davfra <64629389+davfra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.