Split jumpstart and register flows #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…starting These flows are going to be different since the user registration flow shouldn't involve any DKG going forward.
JesseAbram
approved these changes
Jul 18, 2024
Tbh don't know what the right values for this are, and we should really be encoding the data stucture instead of hardcoding it, but 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the jumpstart flow makes use of the registration flow's DKG infrastructure.
Since registration is not going to be using this in the future it makes sense to split
them up and give jumpstart a bit more of a dedicated codepath.
To do so I've added a new endpoint to the TSS,
/generate_network_key, which behind thescenes uses the same code that the
/user/newendpoint does.