Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jumpstart network #918
Jumpstart network #918
Changes from 24 commits
2ea8b13
596b50f
0518683
c2fbb1e
88478a5
b11c139
063e9cd
18ccbff
7e75fb2
a1d690b
1c27b58
5b2d3d4
517109e
e236be6
1600811
7c77aea
879cba6
84c1770
8c7338d
237078b
0466073
f726f51
5fcacb0
8917d32
cc7e7de
1ec04d7
4d8fb55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion: instead of overwriting the parent's verifying key to be
0x00
we couldhave a separate "forbidden key" entry,
PARENT_VERIFYING_KEY
, which points to the parentverifying key.
For those checks you mention, we could achieve them the same way, but doing an extra
lookup.
That way we keep the verifying key entries consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure at this point tho im in favour of opening an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah an issue is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#931