Add validator helpers to cli #870
Conversation
crates/test-cli/src/lib.rs
Outdated
| /// | ||
| /// Optionally may be preceeded with "//", eg: "//Alice" | ||
| #[arg(short, long)] | ||
| //. The mnemonic to use for the call |
There was a problem hiding this comment.
Same here - also typo (doccomment needs three slashes)
crates/test-cli/src/lib.rs
Outdated
|
|
||
| println!("User account: {}", user_keypair.public()); | ||
|
|
||
| let change_endpoint_tx = |
There was a problem hiding this comment.
IMO these should be done in a function in entropy-client ./crates/client/src/client.rs. This makes it possible to test them, and to call them from other client software.
| new_endpoint: String, | ||
| // The mnemonic to use for the call, should be stash address | ||
| #[arg(short, long)] | ||
| mnemonic_option: Option<String>, |
There was a problem hiding this comment.
As I already said with the other ones, i think --mnemonic-option is not a good name for this argument. In the context of this CLI this a mandatory argument. If they don't give it the command will not work.
There was a problem hiding this comment.
So we shouldn't even have this as an Option then, eh?
There was a problem hiding this comment.
no it will work if the mnemonic is in the environment, a mnemonic is needed but it is not needed to be passed in
crates/test-cli/src/lib.rs
Outdated
| }, | ||
| /// Allows a validator to change their endloint | ||
| ChangeEndpoint { | ||
| /// New endpoint to change to |
There was a problem hiding this comment.
I would give an example of the expected format. Although I guess that can take all sorts of different forms, from bare IP addresses to FQDNs
crates/test-cli/src/lib.rs
Outdated
| ChangeEndpoint { | ||
| /// New endpoint to change to | ||
| new_endpoint: String, | ||
| // The mnemonic to use for the call, should be stash address |
There was a problem hiding this comment.
And I guess to be more specific, this is the validator stash account, correct?
| new_endpoint: String, | ||
| // The mnemonic to use for the call, should be stash address | ||
| #[arg(short, long)] | ||
| mnemonic_option: Option<String>, |
There was a problem hiding this comment.
So we shouldn't even have this as an Option then, eh?
| let result_event = in_block | ||
| .find_first::<entropy::staking_extension::events::EndpointChanged>()? | ||
| .ok_or(anyhow!("Error with transaction"))?; | ||
| println!("Event result: {:?}", result_event); |
There was a problem hiding this comment.
I'd be a bit more specific with what we're printing here
There was a problem hiding this comment.
well this one returns an event that is pretty descriptive and has the extra data needed
crates/test-cli/src/lib.rs
Outdated
|
|
||
| let user_keypair = <sr25519::Pair as Pair>::from_string(&mnemonic, None)?; | ||
|
|
||
| println!("User account: {}", user_keypair.public()); |
There was a problem hiding this comment.
I'd also be more specific here (and same for the other command)
Closes #865