Test CLI store program command no longer defaults to the barebones program #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseAbram
approved these changes
May 29, 2024
There was a problem hiding this comment.
oh, I already removed this in #856 but did not remove it from the cargo.toml, I can do that now and we can avoid this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store program command in the test-cli now takes a program file as a mandatory positional argument. Before it was optional and fell back to the barebones program.
Removing this means we can remove the dependency
entropy-testing-utilswhich in turn hasentropy-tssas a dependency. This means we have quite a few less dependencies.We do still need openssl so this doesn't fix #855 - but it might reduce the need for some other packages.
See related discussion: #856 (comment)