Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Account Deserialization error from verifying key mismatch #831

Merged
merged 6 commits into from
May 14, 2024

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented May 13, 2024

Fixes Account deserilization error by passing veryifying key instead of sig req account

@JesseAbram JesseAbram requested review from HCastano and ameba23 and removed request for HCastano May 13, 2024 20:43
@HCastano HCastano changed the title Hot fix v0.0.12 rc2 Fix Account Deserialization error from verifying key mismatch May 13, 2024
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's try and see if this fixes registration

@@ -95,6 +95,7 @@ pub struct UserRegistrationInfo {
pub value: Vec<u8>,
/// Is this a proactive refresh message
pub proactive_refresh: bool,
pub sig_request_address: Option<SubxtAccountId32>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs

crates/threshold-signature-server/src/user/api.rs Outdated Show resolved Hide resolved
JesseAbram and others added 2 commits May 13, 2024 18:36
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fingers crossed for rc3-beta. Im guessing it is already deployed while ive been sleeping.

@JesseAbram JesseAbram merged commit ce3ab55 into master May 14, 2024
11 checks passed
@JesseAbram JesseAbram deleted the hot-fix-v0.0.12-rc2 branch May 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants