Make full version of entropy-client possible to compile on wasm
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseAbram
approved these changes
May 6, 2024
crates/client/src/client.rs
Outdated
| @@ -124,8 +123,9 @@ pub async fn register( | |||
| _ => None, | |||
| }; | |||
|
|
|||
| let account_id32: AccountId32 = signature_request_keypair.public().into(); | |||
| let account_id: <EntropyConfig as Config>::AccountId = account_id32.into(); | |||
| // let account_id32: AccountId32 = signature_request_keypair.public().into(); | |||
There was a problem hiding this comment.
if it isn't needed let's remove
crates/client/src/client.rs
Outdated
| let account_id: <EntropyConfig as Config>::AccountId = account_id32.into(); | ||
| // let account_id32: AccountId32 = signature_request_keypair.public().into(); | ||
| let account_id: <EntropyConfig as Config>::AccountId = | ||
| SubxtAccountId32(signature_request_keypair.public().0); | ||
|
|
||
| for _ in 0..50 { | ||
| let block_hash = rpc.chain_get_block_hash(None).await.unwrap(); |
There was a problem hiding this comment.
hmmm is an unwrap here ok, or should we error handle better?
There was a problem hiding this comment.
Good catch, we should definitely error handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes to
entropy-clientto make it possible to compile on wasm with thefull-clientfeature flag enabled